Skip to content

Change the method name "make" to "getNameId". #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change the method name "make" to "getNameId". #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions fop-core/src/main/java/org/apache/fop/fo/properties/TableBorderPrecedence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,34 @@ public TableBorderPrecedence(int propId) {
*
* {@inheritDoc}
*/
public Property getNameId(PropertyList propertyList) throws PropertyException {
FObj fo = propertyList.getFObj();
switch (fo.getNameId()) {
case Constants.FO_TABLE:
return num6;
case Constants.FO_TABLE_CELL:
return num5;
case Constants.FO_TABLE_COLUMN:
return num4;
case Constants.FO_TABLE_ROW:
return num3;
case Constants.FO_TABLE_BODY:
return num2;
case Constants.FO_TABLE_HEADER:
return num1;
case Constants.FO_TABLE_FOOTER:
return num0;
default:
return null;
}
}

/**
* Set default precedence according to the parent FObj
*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*
* @deprecated Use {@link #getNameId(PropertyList)} instead

* {@inheritDoc}
*/
@Deprecated
public Property make(PropertyList propertyList) throws PropertyException {
FObj fo = propertyList.getFObj();
switch (fo.getNameId()) {
Expand Down