-
Notifications
You must be signed in to change notification settings - Fork 145
[YUNIKORN-2981] Support filtering schedulerName #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 68.01% 68.05% +0.04%
==========================================
Files 72 72
Lines 9291 9304 +13
==========================================
+ Hits 6319 6332 +13
+ Misses 2760 2756 -4
- Partials 212 216 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We should only ever override the So in processPod before checking user info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kaichiachen, thanks for submitting the PR. One comment from me.
What is this PR for?
Implements scheduler name filtering in Yunikorn's admission controller to support environments with multiple schedulers
Key changes:
admissionController.filtering.overrideCustomSchedulers
yunikorn
forcely ifadmissionController.filtering.overrideCustomSchedulers
is true or pod scheduler name isdefault-scheduler
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2981
How should this be tested?
Screenshots (if appropriate)
Questions: