Refactor simple_preemptor E2E test suite structure #971
Conversation
Signed-off-by: Alex Wu <[email protected]>
There was a problem hiding this comment.
Hi @popojk, thanks for submitting this PR. Could you check the lint error in CI?
You can run make lint to validate it.
Signed-off-by: Alex Wu <[email protected]>
|
Hi @chenyulin0719 . I've fixed the lint issue, could you please help me to run the CI again? Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 67.89% 68.09% +0.20%
==========================================
Files 72 72
Lines 9294 9294
==========================================
+ Hits 6310 6329 +19
+ Misses 2768 2750 -18
+ Partials 216 215 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| sleepPodMemLimit2 = int64(float64(Worker2Res.Value())/3.5) / (1000 * 1000) | ||
| }) | ||
|
|
||
| var _ = ginkgo.BeforeEach(func() { |
There was a problem hiding this comment.
How about placing BeforeEach at the same level as AfterEach? Under the scope of ginkgo.Describe("SimplePreemptor", func() {. I prefer to keep it consistent.
There was a problem hiding this comment.
agree: should be moved between the Describe and the It below
| }) | ||
|
|
||
| var _ = ginkgo.AfterSuite(func() { | ||
|
|
There was a problem hiding this comment.
nit: unneeded empty line
| sleepPodMemLimit2 = int64(float64(Worker2Res.Value())/3.5) / (1000 * 1000) | ||
| }) | ||
|
|
||
| var _ = ginkgo.BeforeEach(func() { |
There was a problem hiding this comment.
agree: should be moved between the Describe and the It below
3 participants
What is this PR for?
Refactor simple_preemptor E2E test suite structure
What type of PR is it?
What is the Jira issue?
issue link