[YUNIKORN-3114] change yaml package #983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change import from "gopkg.in/yaml.v3" to "go.yaml.in/yaml/v3"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 65.87% 65.89% +0.02%
==========================================
Files 72 72
Lines 9297 9297
==========================================
+ Hits 6124 6126 +2
+ Misses 2961 2959 -2
Partials 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manirajv06
reviewed
Aug 18, 2025
| gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect |
There was a problem hiding this comment.
Does this older version of yaml used by some other deps?
There was a problem hiding this comment.
Correct - we're no longer using it directly after the PR is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Change import from "gopkg.in/yaml.v3" to "go.yaml.in/yaml/v3"
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3114
How should this be tested?
Screenshots (if appropriate)
Questions: