[YUNIKORN-3076] WebUI fails to load apps that are in 'New' state and … #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…does not have stateLog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 35.71% 35.71%
=======================================
Files 2 2
Lines 56 56
=======================================
Hits 20 20
Misses 33 33
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
craigcondit
approved these changes
May 15, 2025
|
Thanks for the review @craigcondit |
wilfred-s
approved these changes
May 26, 2025
wilfred-s
pushed a commit
that referenced
this pull request
May 27, 2025
When an application is reported to be in a 'New' state by the scheduler, it does not have a stateLog object. On the web UI side, there are currently no checks to handle the absence of the stateLog object. As a result, when the application list contains an application in the 'New' state and the stateLog is missing, the code attempts to access this.stateLog, leading to a failure and preventing the page from loading any applications. Closes: #233 Signed-off-by: Wilfred Spiegelenburg <[email protected]> (cherry picked from commit 541135b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…does not have stateLog
What is this PR for?
This pull request addresses an issue in the web UI where the absence of a stateLog object for applications in the 'New' state causes the page to fail loading the list of applications. By setting a default value for the stateLog object and ensuring it is an Array object, we ensure that the application list can be loaded and displayed correctly, even when some applications are in the 'New' state without a stateLog.
Issue:
When an application is reported to be in a 'New' state by the scheduler, it does not have a stateLog object. On the web UI side, there are currently no checks to handle the absence of the stateLog object. As a result, when the application list contains an application in the 'New' state and the stateLog is missing, the code attempts to access this.stateLog, leading to a failure and preventing the page from loading any applications.
This behavior has been observed on clusters with heavy load.
What type of PR is it?
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: