Skip to content

Conversation

kousei47747
Copy link

What is this PR for?

Upgrade webapp to Angular 20.
For compatibility, Node has been upgraded to 20, and TypeScript to 5.8.
The watch=false flag was added to the test:coverage command to prevent it from getting stuck — likely due to the interaction between Node 20 and Karma.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-3073

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.71%. Comparing base (541135b) to head (1d0eebb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   35.71%   35.71%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           20       20           
  Misses         33       33           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chenyulin0719
Copy link
Contributor

chenyulin0719 commented Jun 13, 2025

Hi @kousei47747 , I got an error while building web image. Do you have the same error after running make clean image?

image

@chenyulin0719 chenyulin0719 self-requested a review June 13, 2025 13:36
@kousei47747
Copy link
Author

Hi @chenyulin0719 thanks for reviewing! It works both on my local and github actions.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, image built sucessfully on my Mac.

@wilfred-s wilfred-s closed this in 953d08a Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants