Skip to content

[ZEPPELIN-6063] Fix delay in paragraph results rendering in new UI #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

tbonelee
Copy link
Contributor

@tbonelee tbonelee commented Aug 23, 2024

What is this PR for?

In new UI, the results are rendered only after some interactions, such as a click on the other paragraph.

This PR addresses the issue by ensuring immediate rendering of the results when they are set in the ngAfterViewInit lifecycle hook. Previously, markForCheck() was used after setting this.innerHTML, which scheduled the component to be checked in the next change detection cycle but did not trigger an immediate update.
This has been changed to detectChanges() to force an immediate change detection, ensuring that the results are rendered right after they are set, without needing further user interaction.

What type of PR is it?

Bug Fix

What is the Jira issue?

How should this be tested?

  • Run any paragraph in new UI

Screenshots (if appropriate)

Before

Aug-23-2024 19-59-47

After

Aug-23-2024 20-27-01

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@tbonelee tbonelee changed the title [ZEPPELIN-4293] Fix delay in paragraph results rendering in new UI [ZEPPELIN-6063] Fix delay in paragraph results rendering in new UI Aug 23, 2024
@tbonelee tbonelee closed this Aug 23, 2024
@tbonelee tbonelee reopened this Aug 23, 2024
Copy link
Member

@jongyoul jongyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pan3793 pan3793 merged commit 364a556 into apache:master Aug 26, 2024
28 checks passed
@pan3793
Copy link
Member

pan3793 commented Aug 26, 2024

Thanks, merged to master

@tbonelee tbonelee deleted the fix-results-rendering branch August 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants