[ZEPPELIN-6084] Update jena-arq to 4.10 #4886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
commented
Oct 28, 2024
| @@ -108,6 +108,10 @@ void testSuccessfulRawQuery() { | |||
| assertEquals(Code.SUCCESS, result.code()); | |||
|
|
|||
| final String expected = "?subject\t?predicate\t?object\n" + | |||
There was a problem hiding this comment.
Apparently the sorting has been changed a little. I hope it doesn't cause any problems.
|
@pjfanning Can you do a review here? |
|
@645775992 Can you review this PR? |
|
Jena is not something I know a great deal about but the changes look ok to me. |
|
It seems that the sparql interpreter does not have integration tests, I don't use sparql, so may not be able to evaluate this change. Is it possible to leverage the testcontainers to build an integration test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is a follow-up to #4507.
I have decided to switch to the latest version 4.x. From 5.x JDK 17 is required. Obsolete functions have been removed.
Note: I do not use the interpreter myself. I have not tested it manually either. I rely on the unit tests.
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Questions: