Changes to windows compatability #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://github.com/docker/docker-py/blob/6e6a273573fe77f00776b30de0685162a102e43f/docker/transport/npipesocket.py#L180 Attempt to get compat working on windows Unfortunately will hang with recv. Might be better to add a caveat in the README.
Scott-Simmons
commented
Jul 26, 2025
Author
Scott-Simmons
left a comment
Scott-Simmons
left a comment
There was a problem hiding this comment.
This PR will stay in draft, it is just up to demonstrate the incompatibility with windows (and a naive attempt at fixing)
Comment on lines
+206
to
+211
| while b := read_func(1024): | ||
| print("This is b") | ||
| print(b) | ||
| container_response += b | ||
| print("This is the container response:") | ||
| print(container_response) |
Author
There was a problem hiding this comment.
It works for the first recv call but then hangs.
Probably b/c named pipes are different to sockets
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/docker/docker-py/blob/6e6a273573fe77f00776b30de0685162a102e43f/docker/transport/npipesocket.py#L180
Attempt to get compat working on windows
Unfortunately will hang with recv. Might be better to add a caveat in the README.