Skip to content

Conversation

myceliaes
Copy link
Collaborator

I’m sorry for the 8 million commits. There were problems

@myceliaes myceliaes requested a review from mauraoleary April 30, 2025 02:07
Copy link
Collaborator

@mauraoleary mauraoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sending it back to you as a test

Copy link
Collaborator

@mauraoleary mauraoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

columns not aligned for all A words

Copy link
Collaborator

@mauraoleary mauraoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing misalignment - let's check today

Copy link
Member

@jonorthwash jonorthwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitions for = and - and any other symbol used in the comments column should be made available in the file somewhere.

Copy link
Collaborator

@mauraoleary mauraoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to do this, but we would like to change all of the "=" signs to "-" signs. The columns in this file are also not totally aligned.

You can do this small edit this in github directly by going to this pull request, then to the "files changed" tab, then finding the three-dot menu on the far right hand side just above the code and choosing "edit." After editing and hitting "commit changes," you can then rerequest review by going to the "conversations" tab, finding my name on the right hand side and hitting the two arrows in a circle button next to my name.

Thank you!

@myceliaes myceliaes requested a review from mauraoleary May 31, 2025 00:56
Copy link
Member

@jonorthwash jonorthwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some alignment issues with the entry for "minister".

trying to fix spacing issues
Copy link
Member

@jonorthwash jonorthwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment looks good now.

However it seems all of the "apostrophes" are the smart quote character ’ instead of the glottal stop character ʼ. There appears to have been a mix before you got to it—let's use this as an opportunity to clean up this section at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants