Skip to content

d_nouns #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

d_nouns #16

wants to merge 8 commits into from

Conversation

nkwasson
Copy link
Collaborator

No description provided.

@nkwasson nkwasson requested a review from mauraoleary April 30, 2025 02:26
mauraoleary
mauraoleary reviewed May 16, 2025
View reviewed changes
Copy link
Collaborator

@mauraoleary mauraoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jonorthwash
Copy link
Member

We're going to change = to - in the bare? column. Could you update the PR with that?

@jonorthwash jonorthwash self-requested a review May 20, 2025 23:39
jonorthwash
jonorthwash requested changes May 20, 2025
View reviewed changes
Copy link
Member

@jonorthwash jonorthwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert = to - in bare? column.

@nkwasson
Copy link
Collaborator Author

Great, I made that change!

jonorthwash
jonorthwash reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@jonorthwash jonorthwash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some words have different lemmas and roots, e.g. drèe’:drèe[-bare]. I just want to make sure this is correct.

I also can't tell the difference between the two dzàyy’:dzàyy[-bare] entries.

@mauraoleary
Copy link
Collaborator

@jonorthwash
There are now two words that mean different things "blouse" and "rib cage" but have identical forms. Normally, we would just combine them into one entry, but "rib cage" is [-bare] and "blouse" is not. Any thoughts on what to do with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorthwash jonorthwash jonorthwash requested changes

@mauraoleary mauraoleary mauraoleary left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@jonorthwash jonorthwash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkwasson @jonorthwash @mauraoleary @EPAUL04