Skip to content

feat: add Camoufox-based Crawlee JS/TS templates#336

Merged
B4nan merged 7 commits intomasterfrom
feat/camoufox-templates
Feb 27, 2025
Merged

feat: add Camoufox-based Crawlee JS/TS templates#336
B4nan merged 7 commits intomasterfrom
feat/camoufox-templates

Conversation

@barjin
Copy link
Member

@barjin barjin commented Feb 26, 2025

Following the apify/apify-sdk-js#364 and apify/crawlee#2842 , this PR adds Camoufox-enabled templates to Apify Actor templates. The implementation is heavily based on the existing Playwright + Chrome templates.

The only issue (I'm aware of) currently is the immense size of those images (as they contain Chrome and we add Camoufox binaries). Installing Camoufox directly to a node-debian image results in missing system dependencies. While it might be possible to install those manually in the Dockerfile, it might make the Dockerfile too complex for a regular user.

image

@barjin barjin self-assigned this Feb 26, 2025
@github-actions github-actions bot added this to the 109th sprint - Tooling team milestone Feb 26, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 26, 2025
@barjin barjin force-pushed the feat/camoufox-templates branch from 459e3a2 to 324cfe6 Compare February 26, 2025 14:33
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 26, 2025
@B4nan
Copy link
Member

B4nan commented Feb 26, 2025

The only issue (I'm aware of) currently is the immense size of those images (as they contain Chrome and we add Camoufox binaries). Installing Camoufox directly to a node-debian image results in missing system dependencies. While it might be possible to install those manually in the Dockerfile, it might make the Dockerfile too complex for a regular user.

Let's deal with that once we see camoufox is the right bet. I guess we would also add a custom camoufox base docker image, maybe even CamoufoxCrawler if it would make things easier to use.

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i would just update the readmes to mention camoufox

@barjin
Copy link
Member Author

barjin commented Feb 27, 2025

I see the failing tests are only Python-related now. I suppose removing the templates later if they break wouldn't be a breaking change anyway, right?

@B4nan B4nan merged commit e6c0c28 into master Feb 27, 2025
18 of 23 checks passed
@B4nan B4nan deleted the feat/camoufox-templates branch February 27, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants