-
Notifications
You must be signed in to change notification settings - Fork 31
feat: call-actor tool #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just a couple of comments. Please be sure to also add integration tests to the tests/integration/suite.ts for the call-actor tool. I would also personally move the tool to a separate file tools/call-actor.ts (but it's fine for now, we should refine the strucutre later on - there is an issue for that).
I wrote two simple tests: run them after the Actor is added to check if they work, and run them without adding an actor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #155
Generic tool for calling Actors dynamically, for clients without support for the dynamic tools list.
TODO: