feat: add dataset.statistics #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MFori
added
the
t-console
github-actions
bot
added
the
tested
drobnikj
reviewed
Jan 7, 2025
| const response = await this.httpClient.call(requestOpts); | ||
| return cast(pluckData(response.data)); | ||
| } catch (err) { | ||
| catchNotFoundOrThrow(err as ApifyApiError); |
There was a problem hiding this comment.
I'm not sure about this, should be the same as listItems and return not found error once the dataset does not exist?
There was a problem hiding this comment.
I agree it makes more sense to me too, but I got inspired by DatasetClient.get() which doesn't throw if dataset not exists 🤔 (which I would expect to also throw)
There was a problem hiding this comment.
I would also prefer throwing when things are not there, but we should be consistent, and it looks like most methods use the catchNotFoundOrThrow approach.
There was a problem hiding this comment.
catchNotFoundOrThrow feels confusing, if you get undefinied, you have no idea if the dataset does not exist or statistics missing.
drobnikj
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/apify/apify-core/issues/18807 - Implementation of new API endpoint
v2/datasets/{datasetId}/statistics