Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add spell check capabilities to Vale linter #1345

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

TC-MO
Copy link
Contributor

@TC-MO TC-MO commented Dec 11, 2024

No description provided.

@github-actions github-actions bot added the t-docs Issues owned by technical writing team. label Dec 11, 2024
@TC-MO TC-MO requested review from B4nan and netmilk December 12, 2024 09:35
@TC-MO TC-MO marked this pull request as ready for review December 12, 2024 09:35
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the CI is happy, I am happy 🙃

@TC-MO TC-MO requested a review from honzajavorek as a code owner December 13, 2024 10:35
add datacenter to accept.txt
fix issues with mdlint on milvus integration page
remove unnecessary vale off & on comments due to fixing accept & reject
vocabularies
@TC-MO
Copy link
Contributor Author

TC-MO commented Dec 18, 2024

@fnesveda , @mtrunkat This should help with typos throughout PR's. While our previous tool started strong (catching over 100 typos), it eventually started missing some pretty obvious ones.

Vale is much more reliable ,with much bigger dictionary, and will actually block merges until typos are fixed. Plus, we can make it even smarter by adding our own regex-based rules to accept.txt & reject.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-docs Issues owned by technical writing team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants