Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Session binding capability via
session_id
inRequest
#1086feat: add Session binding capability via
session_id
inRequest
#1086Changes from 7 commits
38b5531
08a7d01
a67d3b3
039f12f
88c0e8c
7fb5fde
300cf4f
6037829
5e94912
25a21a0
14b8974
d633930
b5fc9a4
1a8cd22
b5d1dc5
9557ac5
448f9e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't
session_id
be used forunique_key
computation? I expect that users might get hindered by deduplication if they try to re-enqueue a failed request with a different session.CC @vdusek - you wrote a big part of the unique key functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, deduplication will affect this.
But I expect that users will use existing mechanisms to return a
Request
to theQueue
avoiding deduplication. By passing eitherunique_key
oralways_enqueue=True
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Currently, it infers the
unique_key
from the URL, method, headers, and payload (in its extended form). You can, of course, usesession_id
together withalways_enqueue
and it will work, but that feels like a workaround to me. I believe we should include thesession_id
in the extendedunique_key
computation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to call this
check_request_collision
or something like that. Now the name sounds like it's always going to raise an error, which is not the case.