-
Notifications
You must be signed in to change notification settings - Fork 149
Add HTTPS upstream proxy support with option to ignore proxy cert errors #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @patrickkfkan, Thank you |
Hello! I missed the part where |
Hey, thanks for the fix. I noticed the lint is failing. Could you please rebase your PR on top of the current |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm almost ready to merge this PR, just a few small nits. Could you please take a look at them? Thanks
src/tcp_tunnel_tools.ts
Outdated
}, | ||
callback?: (error: Error | null, result?: string) => void, | ||
): Promise<string> { | ||
const parsedProxyUrl = new URL(proxyUrl); | ||
if (parsedProxyUrl.protocol !== 'http:') { | ||
throw new Error(`The proxy URL must have the "http" protocol (was "${proxyUrl}")`); | ||
if (parsedProxyUrl.protocol !== 'http:' && parsedProxyUrl.protocol !== 'https:') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please do something with an array ['http:', 'https:']
and not in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This feature has landed in |
As title. E.g.:
Anonymize:
Create tunnel: