Skip to content

chore: update shared eslint config to a stable version #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

jirimoravcik
Copy link
Member

This PR updates the @apify/eslint-config to a stable version

@jirimoravcik jirimoravcik added the adhoc Ad-hoc unplanned task added during the sprint. label Mar 21, 2025
@jirimoravcik jirimoravcik requested a review from Copilot March 21, 2025 14:29
@github-actions github-actions bot added this to the 111th sprint - Platform Team milestone Mar 21, 2025
@github-actions github-actions bot added the t-platform Issues with this label are in the ownership of the platform team. label Mar 21, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the shared ESLint configuration to a stable version and changes various module import paths to use the "node:" prefix for improved clarity and compatibility.

  • Updated the ESLint config import from the generic to the TypeScript-specific config.
  • Updated module imports to use Node.js’s new "node:" specifiers in several source files.
  • Adjusted import paths in CI-related scripts and server-related files.

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
eslint.config.mjs Updated the ESLint config import to reference a TypeScript-specific file
src/socket.ts Changed module import paths from 'net' and 'tls' to 'node:net' and 'node:tls'
src/utils/count_target_bytes.ts Changed module import and added an eslint-disable comment in a helper function
src/statuses.ts Updated import path for http’s STATUS_CODES
src/tcp_tunnel_tools.ts Updated module imports for net and URL
src/utils/get_basic.ts Updated URL import path
src/custom_response.ts Updated imports for Buffer and http
src/forward_socks.ts Updated module imports for http, stream, URL, and util
src/chain.ts Updated module imports for Buffer, dns, events, http, https, and URL
.github/scripts/before-beta-release.js Updated module imports to use "node:" for child_process, fs, and path
src/forward.ts Updated module imports for dns, http, https, stream, URL, and util
src/server.ts Updated module imports for Buffer, dns, events, http, net, URL, and util
src/direct.ts Updated module imports for Buffer, dns, events, net, and URL
src/chain_socks.ts Updated module imports for Buffer, events, http, net, and URL, reordered import from socks
src/utils/normalize_url_port.ts Updated URL import path
src/anonymize_proxy.ts Updated module imports for Buffer, http, net, and URL
src/utils/parse_authorization_header.ts Updated Buffer import path
src/utils/redact_url.ts Updated URL import path
src/custom_connect.ts Updated module imports for http, net, and util
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

eslint.config.mjs:1

  • Ensure that switching from the base ESLint configuration to a TypeScript-specific configuration is intentional, as this change may affect linting for non-TypeScript files.
import apifyTypescriptConfig from '@apify/eslint-config/ts.js';

src/utils/count_target_bytes.ts:24

  • [nitpick] Consider adding a clarifying comment to explain why an empty function is acceptable in this context, to better document the rationale behind suppressing this eslint rule.
// eslint-disable-next-line @typescript-eslint/no-empty-function

@jirimoravcik jirimoravcik requested a review from tobice March 21, 2025 14:31
@jirimoravcik jirimoravcik merged commit 16bca47 into master Mar 21, 2025
5 checks passed
@jirimoravcik jirimoravcik deleted the chore/update-eslint-config-2 branch March 21, 2025 19:30
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants