feature: Remove SQLite.swift #635
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewriting the SQLiteDotSwiftDatabase class to ApolloSQLiteDatabase and now interacting directly with the SQLite C API. The goal of this rewrite is to remove the third party dependency on SQLite.swift and preserve all existing functionality as is, not add any new functionality.
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 77ee1e742d41faf33a32c5d8 |
AnthonyMDev
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
This looks really great to me! Thanks so much @BobaFetters.
calvincestari
approved these changes
Apr 25, 2025
| @@ -17,10 +17,21 @@ class SQLiteDotSwiftDatabaseBehaviorTests: XCTestCase { | |||
| XCTAssertEqual(rows.count, 1) | |||
|
|
|||
| // Use SQLite directly to manipulate the database (cannot be done with SQLiteDotSwiftDatabase) | |||
There was a problem hiding this comment.
Suggested change
| // Use SQLite directly to manipulate the database (cannot be done with SQLiteDotSwiftDatabase) | |
| // Use SQLite directly to manipulate the database (cannot be done with ApolloSQLiteDatabase) |
| @@ -1,13 +1,13 @@ | |||
| import XCTest | |||
| @testable import ApolloSQLite | |||
| import ApolloInternalTestHelpers | |||
| import SQLite | |||
| import SQLite3 | |||
|
|
|||
| class SQLiteDotSwiftDatabaseBehaviorTests: XCTestCase { | |||
There was a problem hiding this comment.
Suggested change
| class SQLiteDotSwiftDatabaseBehaviorTests: XCTestCase { | |
| class ApolloSQLiteDatabaseBehaviorTests: XCTestCase { |
There was a problem hiding this comment.
Two suggested changes in this file but I'm not completely sold on the value this test is providing, maybe we don't need it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the SQLiteDotSwiftDatabase class to ApolloSQLiteDatabase and now interacting directly with the SQLite C API. The goal of this rewrite is to remove the third party dependency on SQLite.swift and preserve all existing functionality as is, not add any new functionality.