Remove apollo-execution #5978
Merged
Remove apollo-execution #5978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
commented
Jun 17, 2024
Comment on lines
-49
to
-63
| open annotation class com.apollographql.apollo3.annotations/GraphQLAdapter : kotlin/Annotation { // com.apollographql.apollo3.annotations/GraphQLAdapter|null[0] | ||
| constructor <init>(kotlin/String) // com.apollographql.apollo3.annotations/GraphQLAdapter.<init>|<init>(kotlin.String){}[0] | ||
| final val forScalar // com.apollographql.apollo3.annotations/GraphQLAdapter.forScalar|{}forScalar[0] | ||
| final fun <get-forScalar>(): kotlin/String // com.apollographql.apollo3.annotations/GraphQLAdapter.forScalar.<get-forScalar>|<get-forScalar>(){}[0] | ||
| } | ||
| open annotation class com.apollographql.apollo3.annotations/GraphQLName : kotlin/Annotation { // com.apollographql.apollo3.annotations/GraphQLName|null[0] | ||
| constructor <init>(kotlin/String) // com.apollographql.apollo3.annotations/GraphQLName.<init>|<init>(kotlin.String){}[0] | ||
| final val name // com.apollographql.apollo3.annotations/GraphQLName.name|{}name[0] | ||
| final fun <get-name>(): kotlin/String // com.apollographql.apollo3.annotations/GraphQLName.name.<get-name>|<get-name>(){}[0] | ||
| } | ||
| open annotation class com.apollographql.apollo3.annotations/GraphQLObject : kotlin/Annotation { // com.apollographql.apollo3.annotations/GraphQLObject|null[0] | ||
| constructor <init>(kotlin/String = ...) // com.apollographql.apollo3.annotations/GraphQLObject.<init>|<init>(kotlin.String){}[0] | ||
| final val name // com.apollographql.apollo3.annotations/GraphQLObject.name|{}name[0] | ||
| final fun <get-name>(): kotlin/String // com.apollographql.apollo3.annotations/GraphQLObject.name.<get-name>|<get-name>(){}[0] | ||
| } |
There was a problem hiding this comment.
Those annotations have moved as well
martinbonnin
commented
Jun 17, 2024
Comment on lines
+1
to
+45
| schema { | ||
| query: Query | ||
| } | ||
|
|
||
| scalar Fields | ||
|
|
||
| """ | ||
| The root query | ||
| """ | ||
| type Query { | ||
| apolloClients: [ApolloClient!]! | ||
|
|
||
| """ | ||
| Returns null if an ApolloClient with the given id is not found. | ||
| """ | ||
| apolloClient(id: ID!): ApolloClient | ||
| } | ||
|
|
||
| type ApolloClient { | ||
| id: ID! | ||
|
|
||
| displayName: String! | ||
|
|
||
| normalizedCaches: [NormalizedCache!]! | ||
|
|
||
| normalizedCache(id: ID!): NormalizedCache | ||
| } | ||
|
|
||
| type NormalizedCache { | ||
| id: ID! | ||
|
|
||
| displayName: String! | ||
|
|
||
| recordCount: Int! | ||
|
|
||
| records: [Record!]! | ||
| } | ||
|
|
||
| type Record { | ||
| key: String! | ||
|
|
||
| fields: Fields! | ||
|
|
||
| sizeInBytes: Int! | ||
| } |
There was a problem hiding this comment.
New apollo-execution can generate a SDL file from the code itself (it's now truly code-first). This file is generated from the Kotlin code and checked in source control to monitor for API changes (just like BCV but for the network boundary)
There was a problem hiding this comment.
Now that I think about it, there should be a "schemaDump" and "schemaCheck" task, just like BCV too, I'll think of something
BoD
pushed a commit
to BoD/apollo-kotlin
that referenced
this pull request
Jul 1, 2024
* Remove apollo-execution * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apollo-executionhas moved to https://github.com/apollographql/apollo-kotlin-execution/