Fix using PQs with subscriptions #6283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
|
Sadly the release-3.x CI has flakes. The integration tests "run on my machine" though so I'm tempted to merge anyways. |
BoD
approved these changes
Nov 27, 2024
|
|
||
| override suspend fun url() = url ?: suspendCoroutine { cont -> | ||
| url = "http://localhost:${server.address().unsafeCast<AddressInfo>().port}/" | ||
| server.on("listening") { _ -> | ||
| val server = requireNotNull(this.server) { "Server is not listening, please call listen() before calling address()" } |
There was a problem hiding this comment.
You're right, it can't, this is a bad copy/paste from v4, I'll remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6276
release-3.xcompile now that jcenter is dead.See test here