Skip to content

Conversation

@gsoltis
Copy link

@gsoltis gsoltis commented Nov 15, 2024

This is a small quality-of-life improvement. As the code comment says, some observability/instrumentation libraries rely on Function.name for the name of express middleware to use in a span. @opentelemetry/instrumentation-express is one example.

This PR returns a named function, rather than an anonymous function, and adds a test to ensure that the middleware is named.

@apollo-cla
Copy link

@gsoltis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Nov 15, 2024

✅ Docs Preview Ready

No new or changed pages found.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@glasser
Copy link
Member

glasser commented Jul 3, 2025

@glasser glasser closed this Jul 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants