demonstrate changes to get esm graphql-js working with jest => use @swc/jest #8083
+1,073
−871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strategy: substitute @swc/jest for ts-jest (A) globally: substitute "ts-jest" with "@swc/jest" in the jest config base file (B) in package using an esm dependency such as graphql canary, override the default transformIgnorePatterns with an exception for our package of interest
❌ Docs preview failedThe preview failed to build. Build ID: c10cc212174e07286347db1c ErrorsGeneral: Failed to fetch GitHub source: OK |
|
Thanks Yaacov. I think this still does show that it takes work and refactoring to make Jest work with ESM, even with modern Node. (Though they actually just put out Jest v30 — I wonder if that helps at all.) (Closing PR since this was more of a demo.) |
|
In my testing, version 30 does not change anything around esm dependencies of a cjs project, may help with an actual esm project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strategy: substitute @swc/jest for ts-jest
(A) globally: substitute "ts-jest" with "@swc/jest" in the jest config base file
(B) in package using an esm dependency such as graphql canary, override the default transformIgnorePatterns with an exception for our package of interest
@swc/jestdrops type checking, but that seems to be taken care of anyway in the pretest script.@swc/jestis also faster!compare with #8082