fix: use encodeURIComponent for the repository input #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bkinzle
commented
Jul 12, 2024
bkinzle
commented
- the artifact registry's client will throw an error if a slash is in the repository's string value, uri-encoding will fix this.
* the artifact registry's client will throw an error if a slash is in the repository's string value, uri-encoding will fix this.
glasser
reviewed
Jul 12, 2024
src/index.ts
Outdated
| @@ -125,9 +125,10 @@ export async function main(): Promise<void> { | |||
|
|
|||
| let dockerRegistryClient: DockerRegistryClient | null = null; | |||
| let finalizeDockerRegistryClient: (() => Promise<void>) | null = null; | |||
| const artifactRegistryRepository = | |||
| const artifactRegistryRepository = encodeURIComponent( | |||
There was a problem hiding this comment.
Is this the right spot? I think this is where the action reads the top level repository from the github workflows config, not the individual docker image from the application-values.yaml file. (It's incredibly confusing that AR and Docker use "repository" to mean different things.)
There was a problem hiding this comment.
were you thinking it should go somewhere within the ArtifactRegistryDockerRegistryClient class itself?
glasser
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.