Add functionality to retrack applications to main for closed PRs #92
Conversation
action.yml
Outdated
| default: 'false' | ||
|
|
||
| cleanup-target-repository: | ||
| description: 'Repository to check PR status for cleanup (required when cleanup-closed-pr-tracking is true). Format: owner/repo' |
There was a problem hiding this comment.
Can't this just be the same repository that is specified in the file's git.repoURL, like in the call to resolveRefToSHA in checkRefsAgainstGitHubAndModifyScalars?
src/index.ts
Outdated
| gitHubClient: GitHubClient, | ||
| logger: PrefixingLogger, | ||
| ): Promise<{ newContents: string; changesCount: number }> { | ||
| const doc = yaml.parseDocument(contents); |
There was a problem hiding this comment.
Have you taken a look at our parseYAML function and the big comment in it? I think that using parseDocument loses formatting (and maybe comments?).
There was a problem hiding this comment.
Yeah this is nicer, I reworked it to use parseYAML and I just needed a minor tweak of findTrackables to make it work.
- Use the existing parseYaml and findTrackables - Remove extra input
|
There was a weird build issue, but I just had to delete some extra files that somehow got in my |
zygen
force-pushed
the
cmoore/foun-566-2
branch
2 times, most recently
from
03b7696 to
e477025
Compare
|
Curious what the weird files were; there is sometimes code-splitting that happens in the bundler... |
|
~170 files in dist/protos/subdirs. I can't get it to generate them again, so 🤷 |
Devs often forget to do this step which causes constant confusion. This will enable a workflow that creates a PR that can be merged to do this easily.