Skip to content

Conversation

sevrai
Copy link

@sevrai sevrai commented Jul 2, 2025

Thank you for the release of the V3. Nonetheless, we encoutered issues while migrating to it with Apollo v4 and graphql-codegen.

Types exposed for withFilter function do not match its implementation:

  • TSource of the filter function is the value returned by the asyncIterator
  • parameters are optionnal in types but required ligne 18. Is there a reason for this signature ?

@apollo-cla
Copy link

@sevrai: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@sevrai sevrai marked this pull request as draft July 7, 2025 11:17
@sevrai sevrai marked this pull request as ready for review July 7, 2025 11:17
@sevrai
Copy link
Author

sevrai commented Jul 15, 2025

Hello @tninesling,

Could you please take a look of this issue?
Migrating to 3.0 of in our stack is proving to be quite challenging.

Thank you in advance for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants