Move operation limits enforcement into a layer #7611
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 98e453b33aa2d2d7240a296c |
goto-bus-stop
commented
Jun 5, 2025
apollo-router/src/plugins/limits/enforce_operation_limits_layer.rs
Outdated
Show resolved
Hide resolved
goto-bus-stop
commented
Jun 5, 2025
| type Service = EnforceOperationLimits<S>; | ||
|
|
||
| fn layer(&self, inner: S) -> Self::Service { | ||
| EnforceOperationLimits { |
There was a problem hiding this comment.
We could also use one of the .map_future-style layers here to implement the service. I think it's a pretty good exercise to get into writing our own services though, once you understand them it's not that hard... and we all need to understand them to work with tower effectively.
goto-bus-stop
force-pushed
the
renee/operation-limits-as-a-layer
branch
from
edfc3f9 to
ead890c
Compare
|
@goto-bus-stop, please consider creating a changeset entry in |
goto-bus-stop
force-pushed
the
renee/operation-limits-as-a-layer
branch
from
ead890c to
fbdda50
Compare
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 3 changed, 0 removedBuild ID: 0206cb525df1b27561168acd URL: https://www.apollographql.com/docs/deploy-preview/0206cb525df1b27561168acd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of the refactoring unlocked by #7610.
Operation limits enforcement can be done in a layer at the supergraph service. This way it's a composable piece of functionality that we can add or remove in a single-line code change. This also means it's done a bit earlier in the pipeline. And that we don't need to thread the generated query metrics through the query planner service just to be able to put it in context. Because we don't need a bunch of hardcoded bits in the query planner service to do this, we can actually move all operation limits code into the limits plugin.