Skip to content

Add experimental "subgraph cache" plugin #7641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

SimonSapin
Copy link
Contributor

Add a new "subgraph cache" plugin that starts as a copy of the "entity cache" plugin, but:

  • With a more accurate name
  • Marked (for now) experimental instead of preview
  • Hidden from schema config (until it’s ready for use)
  • Intended to change significantly (in later PRs) while "entity cache" stays unchanged, to avoid disrupting existing users and decouple the eventual migration from Router version upgrades

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@SimonSapin SimonSapin requested a review from a team as a code owner June 7, 2025 06:18
Copy link
Contributor

github-actions bot commented Jun 7, 2025

@SimonSapin, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@SimonSapin SimonSapin marked this pull request as draft June 7, 2025 06:19
@SimonSapin
Copy link
Contributor Author

I’ve split the commits to try and make review easier, so I suggest reviewing by commit.

At the moment the configuration::tests::schema_generation test fails because 7117b24 effectively broke HIDDEN_FROM_CONFIG_JSON_SCHEMA. I don’t know what pattern_properties is supposed to do, but stuff intended to be hidden ends up being visible in the config schema. @rregitsky, what was the motivation for that commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant