Issue39: Remove wildcard * from registration of RelayHandler #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lleadbet
requested changes
Feb 3, 2025
There was a problem hiding this comment.
There's no way to do this since the README wasn't actually modified, but if you can update the language to say the endpoint must match exactly, that'd ensure there's no confusion that someone could put http://localhost:8080/foo/bar and still expect it to work.
Appreciate the PRs!
|
Moving this to #46. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably safest to merge in #41 first.
Fixes #39
Using the asterisk no longer works, after a "breaking change of an undocumented feature" was introduced.
For details, read here: golang/go#68856 (comment)
uplink-relay will not function at all without making this change with newer versions of go (ie: 1.22.5+)