Focus prioritized UI in on modal open #4707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…505/modal-priority
…505/modal-priority
stuartromanek
changed the title
stuartromanek
commented
Aug 28, 2024
stuartromanek
commented
Aug 28, 2024
stuartromanek
commented
Aug 28, 2024
ETLaurent
reviewed
Sep 2, 2024
…505/modal-priority
ETLaurent
previously approved these changes
Sep 3, 2024
Contributor
ETLaurent
left a comment
ETLaurent
left a comment
There was a problem hiding this comment.
lgtm!
haven't tested but let's run Cypress so that we ensure tests are 🆗
stuartromanek
force-pushed
the
PRO-4505/modal-priority
branch
from
a72f155 to
c4a8a64
Compare
…505/modal-priority
ETLaurent
previously approved these changes
Sep 5, 2024
…505/modal-priority
ETLaurent
reviewed
Sep 23, 2024
modules/@apostrophecms/ui/ui/apos/components/AposButtonSplit.vue
Outdated
Show resolved
Hide resolved
…505/modal-priority
…505/modal-priority
…505/modal-priority
…505/modal-priority
Member
Author
|
@ETLaurent This PR has been on a journey. Can you take a last look? |
…505/modal-priority
…ostrophe into PRO-4505/modal-priority
ETLaurent
requested changes
Oct 9, 2024
Contributor
ETLaurent
left a comment
ETLaurent
left a comment
There was a problem hiding this comment.
just that.
otherwise if Cypress is 🟢 then it's 🆗
CHANGELOG.md
Outdated
|
|
||
|
|
||
| * Takes care of an edge case where Media Manager would duplicate search results. | ||
| * Modules can now have a `before: "module-name"` property in their configuration to run (initialization) before another module. |
Contributor
There was a problem hiding this comment.
should stay in the "### Adds" section
Comment on lines
+891
to
+894
| const priority = this.restoreOnly ? 'save' | ||
| : this.saveMenu ? 'splitSave' | ||
| : this.saveDisabled ? 'cancel' : null; | ||
| return name === priority || null; |
ETLaurent
approved these changes
Oct 9, 2024
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Oct 9, 2024
* upstream/main: Focus prioritized UI in on modal open (apostrophecms#4707) fix a rare race condition (apostrophecms#4755) prevent un-publishing singletons (apostrophecms#4739) PRO-6660: modules order (apostrophecms#4745) remove unused vue-template-compiler dependency (apostrophecms#4752) Fix pnpm: true (apostrophecms#4750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://linear.app/apostrophecms/issue/PRO-4505/%5Baccessibility%5D-focus-primary-button-in-priority
trapFocusnow looks for elements markeddata-apos-focus-priorityand prioritizes it during initial focus settingRelated
What are the specific steps to test this change?
focusprio.mp4
What kind of change does this PR introduce?
(Check at least one)