PRO-6576 fix default values for object fields in widgets and generally unify newInstance implementations #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y unify newInstance implementations
Contributor
boutell
commented
Sep 11, 2024
| newWidget(type) { | ||
| const schema = apos.modules[apos.area.widgetManagers[type]].schema; | ||
| const widget = { | ||
| ...newInstance(schema), |
boutell
commented
Sep 11, 2024
| @@ -1,5 +1,6 @@ | |||
| import AposInputMixin from 'Modules/@apostrophecms/schema/mixins/AposInputMixin'; | |||
| import { klona } from 'klona'; | |||
boutell
commented
Sep 11, 2024
| } | ||
| }, | ||
| getDefault() { | ||
| const object = {}; |
Member
Author
There was a problem hiding this comment.
I totally thought I did this one, thank you
boutell
commented
Sep 11, 2024
| ...this.getDefault(), | ||
| ...docData | ||
| }; | ||
| this.docFields.data = _.merge( |
ETLaurent
requested changes
Sep 11, 2024
CHANGELOG.md
Outdated
Comment on lines
4
to
7
|
|
||
| ### Adds | ||
|
|
||
| * Apostrophe now automatically adds the appropriate default values for new properties in the schema, even for existing documents in the database. This is done automatically during the migration phase of startup. |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Adds | |
| * Apostrophe now automatically adds the appropriate default values for new properties in the schema, even for existing documents in the database. This is done automatically during the migration phase of startup. | |
| ### Adds |
changelog from #4721
CHANGELOG.md
Outdated
Comment on lines
12
to
16
|
|
||
| ### Fixes | ||
|
|
||
| * Apostrophe's migration logic is no longer executed twice on every startup and three times in the migration task. It is executed exactly once, always at the same point in the startup process. This bug did not cause significant performance issues because migrations were only executed once, but there is a small performance improvement. | ||
| * Default properties of object fields present in a widget now populate correctly even if never focused in the editor. |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Fixes | |
| * Apostrophe's migration logic is no longer executed twice on every startup and three times in the migration task. It is executed exactly once, always at the same point in the startup process. This bug did not cause significant performance issues because migrations were only executed once, but there is a small performance improvement. | |
| * Default properties of object fields present in a widget now populate correctly even if never focused in the editor. |
changelog from #4721
Contributor
|
waiting for the Cypress tests to finish. |
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Sep 16, 2024
* upstream/main: (77 commits) PRO-6578: auto import of inline images (apostrophecms#4723) Inline array improvements (apostrophecms#4671) take credit for the fix as well as the "change" (apostrophecms#4725) PRO-6576 fix default values for object fields in widgets and generally unify newInstance implementations (apostrophecms#4722) release 4.7.0 (apostrophecms#4717) allows to render widgets in published mode (for non localized with pu… (apostrophecms#4709) fix subfield imports (it was a bug in fetchRelationships: false) (apostrophecms#4715) Add replaces configuration for editor context menus (apostrophecms#4714) bump uploadfs dep (apostrophecms#4712) add batch operations to pages (apostrophecms#4684) PRO-6477 undhandled promise errors (apostrophecms#4700) fix slat order (apostrophecms#4710) make apostoggle accessible (apostrophecms#4708) Improve context menu positions (apostrophecms#4706) remove focus blockers in page relationship editor (apostrophecms#4702) Release 4.6.1 mergeback (apostrophecms#4703) remove z-index bump on area schema fields, boost menu index (apostrophecms#4699) Pro 6345 fix deprecated sass (apostrophecms#4640) Keep widget focused when menu is open (apostrophecms#4695) skipReplace for changeDocIds (apostrophecms#4694) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One implementation of
newInstanceto bring them all and in the darkness bind themThank you for grinding through this with me Etienne! We were basically done I just hadn't saved a file yet