PRO-6627: Fix array reorder and labels #4740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoDonkey
approved these changes
Oct 2, 2024
Contributor
BoDonkey
left a comment
BoDonkey
left a comment
There was a problem hiding this comment.
Tested and works correctly.
Comment on lines
+135
to
+136
| // FIX: swapping the items does not trigger the watcher | ||
| this.next = this.next.slice(); |
Member
There was a problem hiding this comment.
is this more performant than setting the watcher to deep: true ? (probably)
Contributor
Author
There was a problem hiding this comment.
Hmm, I can't say that. I'm not sure if deep will solve it.
I would assume deep is more CPU intensive as it should compare every property in a deep object (and we already do that in the watcher). This should be a cheap check for Vue (because it fails ===).
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Oct 8, 2024
* upstream/main: Release 4.8.0 (apostrophecms#4742) Enable by default, other tweaks (apostrophecms#4741) PRO-6627: Fix array reorder and labels (apostrophecms#4740) Pro 6518 mobile preview (apostrophecms#4720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What are the specific steps to test this change?
titlefortitleFieldby default (consistent with the Slat list)What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: