Modify disabled prop #4744
Merged
Modify disabled prop #4744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutell
approved these changes
Oct 4, 2024
haroun
added a commit
to haroun/apostrophe
that referenced
this pull request
Oct 9, 2024
* upstream/PRO-4505/modal-priority: Modify disabled prop (apostrophecms#4744) Fix media manager not handling search results properly (sometimes) flex media manager containers remove conditional rendering lint fix line wip split button focus, widget priority button make sure we have modal restore focus to last selected item after prop change remove logs focus considerations for media uploader switch promise timeout for nexttick retry wip wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR is in response to a customer complaint that when an area has
expanded: truethen themaxoption is no longer respected. TheAposAreaMenu.vuecomponent passes bothdisabled: falseandmax-reachedprops. TheAposAreaContextualMenu.vuecomponent then setsdisabledusing both the passed values of disabled and max-reached. The button component, that allows the opening of the expanded widget preview, does not check the value of max-reached, only disabled. This change alters the value ofdisabledbeing passed so that the expanded menu respects max-reached. Closes PRO-6621.What are the specific steps to test this change?
For example:
From the zendesk ticket:
For any given widget whose type is area.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: