Skip to content

Conversation

@myovchev
Copy link
Contributor

@myovchev myovchev commented Oct 7, 2024

Summary

Fix a problem when using pnpm option:

// app.js
require('apostrophe')({
  pnpm: true
});

that results in Apostrophe crash "can not invoke add of undefined".

What are the specific steps to test this change?

Adding the option above is not crashing the instance.

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myovchev myovchev merged commit 0f405b4 into main Oct 8, 2024
8 checks passed
@myovchev myovchev deleted the fix-pnpm-option branch October 8, 2024 12:14
haroun added a commit to haroun/apostrophe that referenced this pull request Oct 9, 2024
* upstream/main:
  Focus prioritized UI in on modal open (apostrophecms#4707)
  fix a rare race condition (apostrophecms#4755)
  prevent un-publishing singletons (apostrophecms#4739)
  PRO-6660: modules order (apostrophecms#4745)
  remove unused vue-template-compiler dependency (apostrophecms#4752)
  Fix pnpm: true (apostrophecms#4750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants