Skip to content

Conversation

@ETLaurent
Copy link
Contributor

@ETLaurent ETLaurent commented Oct 8, 2024

Summary

Remove unused dependency.

cf. https://github.com/apostrophecms/apostrophe/security/dependabot/4

What are the specific steps to test this change?

For example:

  1. Run the website and log in as an admin
  2. Open a piece manager modal and select several pieces
  3. Click the "Archive" button on the top left of the manager and confirm that it should proceed
  4. Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@linear
Copy link

linear bot commented Oct 8, 2024

@ETLaurent ETLaurent requested a review from boutell October 8, 2024 13:55
@ETLaurent ETLaurent marked this pull request as ready for review October 8, 2024 13:55
@ETLaurent ETLaurent merged commit b3eab89 into main Oct 8, 2024
8 checks passed
@ETLaurent ETLaurent deleted the pro-6604-vue-template-compiler branch October 8, 2024 14:22
haroun added a commit to haroun/apostrophe that referenced this pull request Oct 9, 2024
* upstream/main:
  Focus prioritized UI in on modal open (apostrophecms#4707)
  fix a rare race condition (apostrophecms#4755)
  prevent un-publishing singletons (apostrophecms#4739)
  PRO-6660: modules order (apostrophecms#4745)
  remove unused vue-template-compiler dependency (apostrophecms#4752)
  Fix pnpm: true (apostrophecms#4750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants