forked from janus-idp/backstage-plugins
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(report-portal): Fixed search for projects page #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yashoswalyo
commented
May 6, 2024
- Added request to add button on instances page
- Updated readme
- Changed breadcrums color to white
deshmukhmayur
requested changes
May 6, 2024
plugins/report-portal/src/components/ReportPortalGlobalPage/ReportPortalGlobalPage.tsx
Outdated
Show resolved
Hide resolved
yashoswalyo
force-pushed
the
fix/report-portal-ui
branch
from
May 6, 2024 12:58
390dba1
to
801f942
Compare
- Added request to add button on instances page - Updated readme Signed-off-by: Yash Oswal <[email protected]>
deshmukhmayur
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@yashoswalyo the yarn install step seems to be failing. Maybe because you've bumped up the report portal plugin version. Can you update the |
yashoswalyo
force-pushed
the
fix/report-portal-ui
branch
2 times, most recently
from
May 7, 2024 12:45
c7c97ee
to
a9bdf58
Compare
Tests are failing even after adding |
Try removing yarn.locak, nodemodules and try the tests |
yashoswalyo
force-pushed
the
fix/report-portal-ui
branch
from
May 8, 2024 06:46
a9bdf58
to
41fa6e7
Compare
yashoswalyo
force-pushed
the
fix/report-portal-ui
branch
from
May 8, 2024 07:15
41fa6e7
to
03e3f52
Compare
riginoommen
approved these changes
May 8, 2024
yashoswalyo
pushed a commit
that referenced
this pull request
May 13, 2024
* chore(deps): update to backstage 1.26.x Signed-off-by: Paul Schultz <[email protected]> * update to new backend Signed-off-by: Paul Schultz <[email protected]> * update to 1.26.4 Signed-off-by: Paul Schultz <[email protected]> * lint Signed-off-by: Paul Schultz <[email protected]> * fix scripts Signed-off-by: Paul Schultz <[email protected]> * update frontend to match showcase Signed-off-by: Paul Schultz <[email protected]> * format files Signed-off-by: Paul Schultz <[email protected]> * fix keycloak test Signed-off-by: Paul Schultz <[email protected]> * fix(deps): remove react-router-dom from dev dependencies and as it's there in peer dependency (#2) * update to backstage 1.26.5 Signed-off-by: Paul Schultz <[email protected]> * fix kiali Signed-off-by: Paul Schultz <[email protected]> * revert to basic frontend Signed-off-by: Paul Schultz <[email protected]> * fix linting Signed-off-by: Paul Schultz <[email protected]> * fix lint config Signed-off-by: Paul Schultz <[email protected]> * lint files Signed-off-by: Paul Schultz <[email protected]> * update dist-dynamic Signed-off-by: Paul Schultz <[email protected]> * fix resolutions Signed-off-by: Paul Schultz <[email protected]> * update react-router-dom Signed-off-by: Paul Schultz <[email protected]> * fix react deps Signed-off-by: Paul Schultz <[email protected]> * fix deprecations Signed-off-by: Paul Schultz <[email protected]> * potential fix for react Signed-off-by: Paul Schultz <[email protected]> * fix dep resolution Signed-off-by: Paul Schultz <[email protected]> * skip orchestrator test Signed-off-by: Paul Schultz <[email protected]> * add eslint rule Signed-off-by: Paul Schultz <[email protected]> * fix tsc error Signed-off-by: Paul Schultz <[email protected]> * fix(orchestrator): force react dependency to be 18.3 and return test (#3) resolved issue that caused orchestrator to install it's own react version thus causing the test to fail and the entire page to crash. * fix(e2e): update e2e tests to allow guest login (#4) * update common test file Signed-off-by: Paul Schultz <[email protected]> * update lockfiles Signed-off-by: Paul Schultz <[email protected]> * fix react Signed-off-by: Paul Schultz <[email protected]> --------- Signed-off-by: Paul Schultz <[email protected]> Co-authored-by: Jaivardhan Kumar <[email protected]> Co-authored-by: Bat-Zion Rotman <[email protected]> Co-authored-by: Debsmita Santra <[email protected]>
yashoswalyo
added a commit
that referenced
this pull request
May 14, 2024
* fix(report-portal): Fixed search for projects page - Added request to add button on instances page - Updated readme Signed-off-by: Yash Oswal <[email protected]> * fix(report-portal): yarn tsc issue --------- Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo
added a commit
that referenced
this pull request
May 15, 2024
Signed-off-by: Yash Oswal <[email protected]> feat(report-portal): add global page for report portal plugin (#1) - added Instances Page - added Projects Page - added Launches Page - Updated Report Portal API - Added api pagination for table - fixed tsc and lint issues in backend plugin - added Readme files for both plugins - added report portal icon componet (#2) fix(report-portal): Fixed search for projects page (#3) - fix(report-portal): Fixed search for projects page - Added request to add button on instances page - Updated readme - fix(report-portal): yarn tsc issue --------- Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo
added a commit
that referenced
this pull request
Jun 19, 2024
Signed-off-by: Yash Oswal <[email protected]> feat(report-portal): add global page for report portal plugin (#1) - added Instances Page - added Projects Page - added Launches Page - Updated Report Portal API - Added api pagination for table - fixed tsc and lint issues in backend plugin - added Readme files for both plugins - added report portal icon componet (#2) fix(report-portal): Fixed search for projects page (#3) - fix(report-portal): Fixed search for projects page - Added request to add button on instances page - Updated readme - fix(report-portal): yarn tsc issue --------- Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo
added a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Yash Oswal <[email protected]> feat(report-portal): add global page for report portal plugin (#1) - added Instances Page - added Projects Page - added Launches Page - Updated Report Portal API - Added api pagination for table - fixed tsc and lint issues in backend plugin - added Readme files for both plugins - added report portal icon componet (#2) fix(report-portal): Fixed search for projects page (#3) - fix(report-portal): Fixed search for projects page - Added request to add button on instances page - Updated readme - fix(report-portal): yarn tsc issue --------- Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo
added a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Yash Oswal <[email protected]> feat(report-portal): add global page for report portal plugin (#1) - added Instances Page - added Projects Page - added Launches Page - Updated Report Portal API - Added api pagination for table - fixed tsc and lint issues in backend plugin - added Readme files for both plugins - added report portal icon componet (#2) fix(report-portal): Fixed search for projects page (#3) - fix(report-portal): Fixed search for projects page - Added request to add button on instances page - Updated readme - fix(report-portal): yarn tsc issue --------- Signed-off-by: Yash Oswal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.