Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report-portal): Fixed search for projects page #3

Merged
merged 2 commits into from
May 8, 2024

Conversation

yashoswalyo
Copy link
Member

  • Added request to add button on instances page

image

  • Updated readme
  • Changed breadcrums color to white

image

@yashoswalyo
Copy link
Member Author

Email template
image

- Added request to add button on instances page
- Updated readme

Signed-off-by: Yash Oswal <[email protected]>
Copy link

@deshmukhmayur deshmukhmayur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@deshmukhmayur
Copy link

@yashoswalyo the yarn install step seems to be failing. Maybe because you've bumped up the report portal plugin version.

Can you update the yarn.lock?

@deshmukhmayur deshmukhmayur self-requested a review May 7, 2024 10:49
@yashoswalyo yashoswalyo force-pushed the fix/report-portal-ui branch 2 times, most recently from c7c97ee to a9bdf58 Compare May 7, 2024 12:45
@yashoswalyo
Copy link
Member Author

Tests are failing even after adding yarn.lock file

@riginoommen
Copy link
Member

Try removing yarn.locak, nodemodules and try the tests

@riginoommen riginoommen merged commit ff9170d into plugin-report-portal May 8, 2024
3 of 5 checks passed
@yashoswalyo yashoswalyo deleted the fix/report-portal-ui branch May 8, 2024 08:32
yashoswalyo pushed a commit that referenced this pull request May 13, 2024
* chore(deps): update to backstage 1.26.x

Signed-off-by: Paul Schultz <[email protected]>

* update to new backend

Signed-off-by: Paul Schultz <[email protected]>

* update to 1.26.4

Signed-off-by: Paul Schultz <[email protected]>

* lint

Signed-off-by: Paul Schultz <[email protected]>

* fix scripts

Signed-off-by: Paul Schultz <[email protected]>

* update frontend to match showcase

Signed-off-by: Paul Schultz <[email protected]>

* format files

Signed-off-by: Paul Schultz <[email protected]>

* fix keycloak test

Signed-off-by: Paul Schultz <[email protected]>

* fix(deps): remove react-router-dom from dev dependencies and as it's there in peer dependency (#2)

* update to backstage 1.26.5

Signed-off-by: Paul Schultz <[email protected]>

* fix kiali

Signed-off-by: Paul Schultz <[email protected]>

* revert to basic frontend

Signed-off-by: Paul Schultz <[email protected]>

* fix linting

Signed-off-by: Paul Schultz <[email protected]>

* fix lint config

Signed-off-by: Paul Schultz <[email protected]>

* lint files

Signed-off-by: Paul Schultz <[email protected]>

* update dist-dynamic

Signed-off-by: Paul Schultz <[email protected]>

* fix resolutions

Signed-off-by: Paul Schultz <[email protected]>

* update react-router-dom

Signed-off-by: Paul Schultz <[email protected]>

* fix react deps

Signed-off-by: Paul Schultz <[email protected]>

* fix deprecations

Signed-off-by: Paul Schultz <[email protected]>

* potential fix for react

Signed-off-by: Paul Schultz <[email protected]>

* fix dep resolution

Signed-off-by: Paul Schultz <[email protected]>

* skip orchestrator test

Signed-off-by: Paul Schultz <[email protected]>

* add eslint rule

Signed-off-by: Paul Schultz <[email protected]>

* fix tsc error

Signed-off-by: Paul Schultz <[email protected]>

* fix(orchestrator): force react dependency to be 18.3 and return test (#3)

resolved issue that caused orchestrator to install it's own react version
thus causing the test to fail and the entire page to crash.

* fix(e2e): update e2e tests to allow guest login (#4)

* update common test file

Signed-off-by: Paul Schultz <[email protected]>

* update lockfiles

Signed-off-by: Paul Schultz <[email protected]>

* fix react

Signed-off-by: Paul Schultz <[email protected]>

---------

Signed-off-by: Paul Schultz <[email protected]>
Co-authored-by: Jaivardhan Kumar <[email protected]>
Co-authored-by: Bat-Zion Rotman <[email protected]>
Co-authored-by: Debsmita Santra <[email protected]>
yashoswalyo added a commit that referenced this pull request May 14, 2024
* fix(report-portal): Fixed search for projects page
- Added request to add button on instances page
- Updated readme

Signed-off-by: Yash Oswal <[email protected]>

* fix(report-portal): yarn tsc issue

---------

Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo added a commit that referenced this pull request May 15, 2024
Signed-off-by: Yash Oswal <[email protected]>

feat(report-portal): add global page for report portal plugin (#1)

- added Instances Page
- added Projects Page
- added Launches Page
- Updated Report Portal API
- Added api pagination for table
- fixed tsc and lint issues in backend plugin
- added Readme files for both plugins
- added report portal icon componet (#2)

fix(report-portal): Fixed search for projects page (#3)

- fix(report-portal): Fixed search for projects page
- Added request to add button on instances page
- Updated readme

- fix(report-portal): yarn tsc issue

---------

Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo added a commit that referenced this pull request Jun 19, 2024
Signed-off-by: Yash Oswal <[email protected]>

feat(report-portal): add global page for report portal plugin (#1)

- added Instances Page
- added Projects Page
- added Launches Page
- Updated Report Portal API
- Added api pagination for table
- fixed tsc and lint issues in backend plugin
- added Readme files for both plugins
- added report portal icon componet (#2)

fix(report-portal): Fixed search for projects page (#3)

- fix(report-portal): Fixed search for projects page
- Added request to add button on instances page
- Updated readme

- fix(report-portal): yarn tsc issue

---------

Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo added a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Yash Oswal <[email protected]>

feat(report-portal): add global page for report portal plugin (#1)

- added Instances Page
- added Projects Page
- added Launches Page
- Updated Report Portal API
- Added api pagination for table
- fixed tsc and lint issues in backend plugin
- added Readme files for both plugins
- added report portal icon componet (#2)

fix(report-portal): Fixed search for projects page (#3)

- fix(report-portal): Fixed search for projects page
- Added request to add button on instances page
- Updated readme

- fix(report-portal): yarn tsc issue

---------

Signed-off-by: Yash Oswal <[email protected]>
yashoswalyo added a commit that referenced this pull request Jun 20, 2024
Signed-off-by: Yash Oswal <[email protected]>

feat(report-portal): add global page for report portal plugin (#1)

- added Instances Page
- added Projects Page
- added Launches Page
- Updated Report Portal API
- Added api pagination for table
- fixed tsc and lint issues in backend plugin
- added Readme files for both plugins
- added report portal icon componet (#2)

fix(report-portal): Fixed search for projects page (#3)

- fix(report-portal): Fixed search for projects page
- Added request to add button on instances page
- Updated readme

- fix(report-portal): yarn tsc issue

---------

Signed-off-by: Yash Oswal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants