Conversation
Moved device identifier fetching (advertisingId, appSetId, androidId) from RegistrationProvider into dedicated domain/data components: - DeviceIdentifiersDataSource: fetches and caches identifiers - DeviceIdentifiersRepository: coordinates data source access - CollectDeviceIdentifiersUseCase: fetches and detects changes - DeviceIdentifiersInteractor: orchestrates fetch with timeout and triggers re-registration when identifiers change Updated RegistrationProvider to read identifiers from repository. Added UseCase/Interactor conventions to CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added tests for all new DeviceIdentifiers domain/data components: - DeviceIdentifiersDataSourceTest: fetch, save, loadCached - DeviceIdentifiersRepositoryTest: delegation, fetchAndroidIdSync - CollectDeviceIdentifiersUseCaseTest: optOut, change detection - DeviceIdentifiersInteractorTest: timeout/in-time scenarios with registration triggering - RegistrationProviderTest: getIdfa, getIdfv, getAndroidId, getDeviceType with optOutOfTracking branches Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added deviceIdentifiersRepository.clear() call in ApphudInternal.clear() to properly reset device identifiers through the repository abstraction during logout, consistent with userRepository.clearUser() and productRepository.reset(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added step-by-step logs with timestamps to DeviceIdentifiersInteractor and CollectDeviceIdentifiersUseCase to trace execution timeline and identify which identifiers change between cached and fetched values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.