Remove_placements: Remove paywalls field from ApphudUser#146
Merged
Remove_placements: Remove paywalls field from ApphudUser#146
Conversation
aaudin90
force-pushed
the
Remove_placements
branch
from
2d2692e to
2d1bdf1
Compare
Remove paywalls from ApphudUser, CustomerDto, CustomerMapper. Update UserRepository to merge only placements (not paywalls). Update PaywallRepository to search paywalls via placements. Remove need_paywalls from RegistrationBody, rename needPaywalls parameter to needPlacements across RegistrationBodyFactory, RemoteRepository, and RegistrationUseCase. Simplify SharedPreferencesStorage migration to placements only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove rawPaywalls(), paywallsDidLoadCallback(), paywallClosed() from Apphud.kt. Remove paywallsDidFullyLoad from ApphudListener. Update ApphudInternal to use placements instead of paywalls for cache checks, readiness checks, retry logic, and log messages. Simplify allAvailableProductIds to use placements and groups only. Update fallback flow to wrap paywalls into placements. Remove paywallClosed/paywallClosedSuspend from RequestManager. Rename needPaywalls to needPlacements in RequestManager. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove paywalls parameter from ApphudUser test fixtures. Simplify UserRepositoryTest to verify placements-only merge logic. Update RegistrationUseCaseTest to remove paywalls preservation tests. Update RemoteRepositoryTest to use needPlacements parameter. Update SharedPreferencesStorageMigrationTest for placements-only migration. Remove paywallsDidFullyLoad callback from demo apps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
aaudin90
force-pushed
the
Remove_placements
branch
from
2d1bdf1 to
c48bedd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
paywallsproperty fromApphudUserand all related public APIs (rawPaywalls,paywallsDidLoadCallback,paywallClosed,paywallsDidFullyLoadlistener callback). Paywalls are now accessed exclusively through placements.paywallsfrom ApphudUser, CustomerDto, CustomerMapper, RegistrationBody, and SharedPreferencesStorage migrationneed_paywallsrequest field, rename toneedPlacementsfindPaywallScreenIdhelper in ApphudInternal+Purchases to eliminate duplicated paywall lookup logicfirstNotNullOfOrNullin PaywallRepository for consistency and to avoid intermediate list allocation