chore(deps): remove cheerio from renovate blacklist #2119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure why CI is failing, it runs just fine on my local Windows 🤔 The slowness from GH's latest Windows runner version isn't helping either. |
Seems like it's not actually obsolete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renovate unexpectedly updated
cheerioto1.1.0so I checked out if it still works, despite the breaking changes in1.0.0. To my surprise - it does.cheeriofrom Renovate blacklist* Remove obsoleteTook a look at the code and it's not actually obsolete. I thought I saw that it was.cheeriooption_useHtmlParser2- while it is replaced with thexmloption, using it failed to load most of the webview contents, whereas they loaded just fine without any extra options.