fix: do not pass process value to browser build #2174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Jul 10, 2025
KazuCocoa
pushed a commit
to projectxyzio/appium-inspector
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight security improvement for the browser version. Currently Vite is configured to pass the entire
process.envobject to the build, which is unneeded. However, it's not a critical issue because the object is only exposed in the dev build (I checked both the preview build and inspector.appiumpro.com).This PR simply changes it to an empty object, eliminating the Vite build warning.
A similar adjustment is added for
process.argv, which also eliminates one console error.