fix: Remove trailing slash from proxyOpts for custom server URL #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
mykola-mokhnach
changed the title
mykola-mokhnach
approved these changes
Apr 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
## [4.3.1](v4.3.0...v4.3.1) (2025-04-09) ### Bug Fixes * Remove trailing slash from proxyOpts for custom server URL ([#308](#308)) ([824a52b](824a52b))
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
paffkata
deleted the
bugfix/wad_url_removing_trailing_slash_from_proxyOpts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you again for accepting my proposal for a change and implementing it so fast. It's just this small bug that's left to fix, so that it works with every possible custom WAD URL. Currently it doesn't work for URLs like this one: http://127.0.0.1:4723. For it, 2 slashes are added like that: http://127.0.0.1:4723//status. The fix fixes this only case where it doesn't work.