Skip to content

[UPDATE JAX API] Update trainer_test _normalized_spec#1201

Closed
Steboss wants to merge 1 commit intoapple:mainfrom
Steboss:sbosisio/update_partition_spec
Closed

[UPDATE JAX API] Update trainer_test _normalized_spec#1201
Steboss wants to merge 1 commit intoapple:mainfrom
Steboss:sbosisio/update_partition_spec

Conversation

@Steboss
Copy link
Contributor

@Steboss Steboss commented May 21, 2025

By running unittests:

XLA_FLAGS='--xla_force_host_platform_device_count=8' pytest --durations=100 -v   -n auto -v -m "for_8_devices" --dist worksteal ${UNQUOTED_PYTEST_FILES}

E             File "/opt/axlearn/axlearn/common/trainer_test.py", line 1093, in <lambda>
E           AttributeError: 'PartitionSpec' object has no attribute '_normalized_spec'
The internal API for `PartitionSpec` has been updated, so `_normalized_spec` is now `_normalized_spec_for_aval` ( [reference](https://github.com/jax-ml/jax/blob/609fb7f6085b52861f65c7aa3b339c40dfd207fa/jax/_src/partition_spec.py#L166) )
@matthew-e-hopkins for visibility

@Steboss Steboss requested review from a team, markblee and ruomingp as code owners May 21, 2025 16:30
Copy link
Contributor

@ruomingp ruomingp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the CI failure?

@Steboss
Copy link
Contributor Author

Steboss commented May 22, 2025

Hey @ruomingp
I can see the following error in the CI for many tests

#22 157.6 /opt/venv/lib/python3.10/site-packages/transformers/integrations/tensor_parallel.py:465: in __init__
#22 157.6     self.input_layouts = (input_layouts or Replicate(),)
#22 157.6 E   NameError: name 'Replicate' is not defined

Any idea? I can investigate on this

@github-actions
Copy link

This pull request has been automatically marked as stale because it has been inactive for 60 days. It will be closed in 7 days if no further activity occurs. If you would like to continue working on this, please remove the stale label or leave a comment.

@github-actions github-actions bot added the stale label Oct 20, 2025
@github-actions github-actions bot removed the stale label Oct 31, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has been inactive for 60 days. It will be closed in 7 days if no further activity occurs. If you would like to continue working on this, please remove the stale label or leave a comment.

@github-actions github-actions bot added the stale label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This pull request was closed because it has been inactive for more than 7 days since being marked as stale. Please feel free to reopen it if you would like to continue.

@github-actions github-actions bot closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants