Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Goodput & Badput recording and monitoring support. #783

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add Goodput & Badput recording and monitoring support. #783

wants to merge 8 commits into from

Conversation

dipannita08
Copy link

@dipannita08 dipannita08 commented Oct 25, 2024 •
edited
Loading

This change adds the following:

  • Upgrades to the latest ml-goodput-measurement library
  • Integrates badput recording into the GoodputRecorder in AxLearn
  • Builds a Goodput monitor to configure and visualize Goodput and Badput using Tensorboard

Tested:

image

markblee
markblee reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@markblee markblee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

axlearn/common/launch_trainer_main.py Outdated Show resolved Hide resolved
@Ethanlm
Copy link
Contributor

Ethanlm commented Oct 25, 2024 •
edited
Loading

Functional end to end testing using fuji-test and fuji-7b (example tensorboard instance)

I don't have access to this link. Can you provide an example that we can take a look

markblee
markblee reviewed Nov 7, 2024
View reviewed changes
axlearn/cloud/gcp/measurement.py Outdated Show resolved Hide resolved
axlearn/cloud/gcp/measurement.py Show resolved Hide resolved
axlearn/cloud/gcp/measurement_test.py Outdated Show resolved Hide resolved
axlearn/cloud/gcp/measurement.py Show resolved Hide resolved
axlearn/common/launch_trainer_main.py Show resolved Hide resolved
@markblee
Copy link
Contributor

markblee commented Nov 7, 2024

Please feel free to "re-request review" when ready. Thanks!

markblee
markblee reviewed Nov 18, 2024
View reviewed changes
axlearn/cloud/gcp/measurement.py Outdated Show resolved Hide resolved
axlearn/cloud/gcp/measurement.py Show resolved Hide resolved
axlearn/common/trainer.py Outdated Show resolved Hide resolved
axlearn/common/trainer.py Outdated Show resolved Hide resolved
axlearn/common/trainer.py Outdated Show resolved Hide resolved
@dipannita08 dipannita08 requested a review from markblee November 25, 2024 21:36
markblee
markblee reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@markblee markblee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@dipannita08 dipannita08 requested a review from markblee December 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruomingp ruomingp Awaiting requested review from ruomingp ruomingp is a code owner

@jiya-zhang jiya-zhang Awaiting requested review from jiya-zhang

@yiping-ma yiping-ma Awaiting requested review from yiping-ma

@markblee markblee Awaiting requested review from markblee markblee is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dipannita08 @Ethanlm @markblee @jiya-zhang @yiping-ma