Add blog post demonstrating using file position in template definitions #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holzensp
force-pushed
the
blogKnowYourPlace
branch
from
4ce1310 to
d841edb
Compare
Comment on lines
+101
to
+106
| It only introduces one "new" concept and that is the concept of a "root" node. | ||
| For `AppEnvCluster.pkl`, the root node is the one _amending the `AppEnvCluster.pkl` module from the `appEnvCluster` package_. | ||
| The function `findRootModule` finds this, by taking the reflection of `module`, and following the amends-chain, until it finds a module, whose `supermodule` does not `amends` anything. | ||
| When it finds that, it reflects back (`mod.reflectee`) to return the `Module` object. | ||
| In `pkl:base`, `Module` is defined with a method `relativePath`, which returns the path of `module` relative to `this` module. | ||
| The path is represented as a `List`, with one `String` per _directory_ -- no file name at the end. |
There was a problem hiding this comment.
I'm not sure it's necessary to go that deep in the how AppEnvCluster finds all the pertinent modules, down to the algorithm. A more generic explanation should suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.