-
Notifications
You must be signed in to change notification settings - Fork 654
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add future wait benchmark to catch memory leaks (#2931)
### Motivation: In the past we introduced a memory leak around the creation of and waiting on futures - we should protect against leaks in this fundamental operation. ### Modifications: Add a new benchmark which would have failed with the previous bug ### Result: Regression protection for this type of memory leak.
- Loading branch information
Showing
4 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Benchmarks/Thresholds/5.10/NIOCoreBenchmarks.WaitOnPromise.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"mallocCountTotal" : 6000, | ||
"memoryLeaked" : 0 | ||
} |
4 changes: 4 additions & 0 deletions
4
Benchmarks/Thresholds/5.8/NIOCoreBenchmarks.WaitOnPromise.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"mallocCountTotal" : 6000, | ||
"memoryLeaked" : 0 | ||
} |
4 changes: 4 additions & 0 deletions
4
Benchmarks/Thresholds/5.9/NIOCoreBenchmarks.WaitOnPromise.p90.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"mallocCountTotal" : 6000, | ||
"memoryLeaked" : 0 | ||
} |