-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FileDescriptor.Pipe()
#58
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fd1e85e
Add Pipe functionality
GeorgeLyon e0d8759
Address feedback
GeorgeLyon 6a99c59
Revert to more verbose names for pipe ends
GeorgeLyon c51b1d1
Use inlet/outlet terminology
GeorgeLyon af3ab71
Remove Pipe struct
GeorgeLyon 534e55f
Merge branch 'main' into dev/george/pipe
GeorgeLyon 18b66f9
Swap input and output
GeorgeLyon 1b37611
No need to retry on interrupt
GeorgeLyon b7bb636
Update Sources/System/Internals/Syscalls.swift
GeorgeLyon 64a60aa
Apply suggestions from code review
GeorgeLyon a210eda
Update Tests/SystemTests/FileOperationsTest.swift
milseman eec2311
Update Tests/SystemTests/FileOperationsTest.swift
milseman 48d4d94
Update Tests/SystemTests/FileOperationsTest.swift
milseman 3c85094
Update Tests/SystemTests/FileOperationsTest.swift
milseman beaeff2
Disable pipe on Windows
GeorgeLyon e80e39c
Update Sources/System/FileOperations.swift
milseman 86ad6f9
Update Sources/System/FileOperations.swift
milseman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably do (not gonna hold up this PR for it though) want to allow for mock testing of such stack local pointers. We'd probably have a variant that we'd pass in an array and it would compare the contents.