Add optional response with claims func. #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colonelpopcorn
commented
Apr 22, 2021
| @@ -312,17 +311,97 @@ func TestLoginHandler(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func performRequest(r http.Handler, method, path string, token string) *httptest.ResponseRecorder { | |||
There was a problem hiding this comment.
I removed this function because it was unused, according to gopls. I'll put it back if its needed.
1 latest: Pulling from appleboy/drone-discord
0s
2 Digest: sha256:5ae60091bcfe8a6d1c97e330fad2d97d95589b6b9f228f118df61b98738c7f85
0s
3 Status: Image is up to date for appleboy/drone-discord:latest
0s
4 2021/04/22 17:54:34 missing discord config
13sBuild failed due to problems above ^^^. |
|
See issue #243 for solution. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a better, non-breaking implementation.