Skip to content

Fix deploy workflow #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2025
Merged

Fix deploy workflow #18

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
634acff
Fix deploy workflow
ipmb Dec 3, 2025
c5d7fe0
Initial plan (#19)
Copilot Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ jobs:
steps:
- uses: actions/checkout@v5
- uses: actions/download-artifact@v5
with:
name: artifact
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The artifact name "artifact" matches the default name used by upload-artifact@v5 at line 33 (which doesn't explicitly specify a name). However, for better clarity and maintainability, consider adding an explicit name parameter to the upload step as well. This makes the artifact naming contract between upload and download explicit rather than relying on defaults.

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@ipmb ipmb Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

path: artifact
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v5
with:
Expand Down