Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunday mob work on Issue 179 - mypy missing library stubs #182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions TODO_issue_179.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Plan for 2024-11-03

SKIP 1 - Import latest approval test
WIP 2 - Run mypi

Jay - I want to work on projects that don't requre tribal knowledge.
Anti-pattern: Offer change (without test). Assume Llewellyn will accept it.



WIP - Option
- Create a bash script (named 'test_issue_179') that exercises problem.
- Demonstrates the problem
- later... figure where to put it as a test


Diana
1 - Do not commit the tox changes in the starter project
Good catch. I did not commit them, but here is the diff to apply to a future starter project

```diff
diff --git a/tox.ini b/tox.ini
index b2c52fb..2c86f56 100644
--- a/tox.ini
+++ b/tox.ini
@@ -9,5 +9,8 @@ deps = -rrequirements.txt

[testenv:dev]
usedevelop = True
-commands =
-
+commands =
+ mypy .
+deps =
+ -rrequirements.txt
+ mypy

```

DONE 2 - Change python3 to be correct python for environment
- Vote for don't care
53 changes: 53 additions & 0 deletions mob-sessions-retros/2024-11-03-retro.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# Retro

## Susan

Learned - I have a better understanding of how to write a bash
script. I wrote it the first time but I didn’t fully understand it
then. Now I have a better understanding.

Felt - I was a bit distracted at the beginning but as with all mobs,
once I jump in, I was still able to follow along. Sometimes I feel
like I don’t need to understand the WHOLE problem to be able to follow
along.


## Jay
learned
- how to create package
- how to use a local package

Trtied to do "rear admiral" (navigate the navigator). It worked for a
while. Was trying to be highest (of 3) levels, letting Jay+Diana deal
with details (as Michael typed).


Probably don't have enough for next week unless all 4 of us show up.
The shared-in-the-headspace gave us momentum. Goldilocks -- not too
much, maybe too little, probably just-right-for-the-context.

Back at work, has a work-around. Less than optimal. Can NOT continue
using the broken module (nor as a producer).

## Diana

Feels great about way in which Diana participated in mob w/ Jay (even
without rotation). Often collaborated w/ Jay in way that she feels
added value.

Example -
- Spealing 'directcary' corecktly. How? Translation of talker. Into
lower level How->what actions.



## Michael
- Jay being silent at beginning was an "offer" (in sense of improv)
for someone to step up. Diana did it. Reluctantly and awkwardly at
first. Then it kept getting better on all fronts. Confidence and
compitence showed on her face.

- Nice offer to have MobbingPattern of "OneTypist".

- I loved having my own ~/.emacs under my fingers. It was pure joy to
type for group.
41 changes: 41 additions & 0 deletions test_issue_179
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#! /bin/bash
set -euo pipefail
set -xv


# script_dir=$(dirname "$0")
script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )



# Producer of package...
# Not in venv to create package
rm -rf dist
python3 setup.py sdist bdist_wheel

# Consumer of package...

# TODO
# - Cleanup this directory
# - cd back to original directory



temp_dir=$(mktemp --directory)
cd "$temp_dir"

python3 -m venv .venv
. ./.venv/bin/activate
pip install mypy



pip install "${script_dir}/dist/approvaltests-14.0.0-py3-none-any.whl"


# TODO
# - Import approval utilities
# - make sub-something works -- 'import approvaltests.xxxxx'

echo "import approvaltests" > test.py
mypy test.py
Loading