Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

. e don't pass environment to tox #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JayBazuzi
Copy link
Contributor

@JayBazuzi JayBazuzi commented Nov 12, 2024

tox (with no arguments), appears to do the right thing. Specifically:

  • tox -e py appears to run testenv
  • just tox runs everything in envlist which is tests, which magically resolves to testenv

The latter seems better, as it lets us make use of envlist.

Here's a screenshot from the GitHub actions showing that tests are still being run with this change:

image

Summary by Sourcery

Enhancements:

  • Remove unnecessary environment variable passing to tox in the test script.

Copy link

sourcery-ai bot commented Nov 12, 2024

Reviewer's Guide by Sourcery

The PR removes the environment specification (-e py) from the tox command in the test runner script, allowing tox to use its default environment configuration.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Simplified tox test execution by removing explicit environment specification
  • Removed '-e py' parameter from tox command
  • Allows tox to use default environment configuration from tox.ini
run_tests.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant